Add [gke] and [test] optional dependencies with kubernetes#288
Open
lukebaumann wants to merge 1 commit into
Open
Add [gke] and [test] optional dependencies with kubernetes#288lukebaumann wants to merge 1 commit into
lukebaumann wants to merge 1 commit into
Conversation
Why: Pathways on Cloud GKE utilities and unit tests require kubernetes and pyyaml. Declaring optional dependency extras [gke] and [test] in pyproject.toml and updating requirements.txt enables installation of GKE and test dependencies. How: - Add gke and test extras to pyproject.toml under [project.optional-dependencies]. - Add kubernetes and pyyaml to requirements.txt. What: - Enables pip install 'pathwaysutils[gke]' and pip install 'pathwaysutils[test]'.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation (Why)
Pathways on Cloud GKE utilities and unit tests require
kubernetesandpyyaml. Declaring optional dependency extras[gke]and[test]inpyproject.tomland updatingrequirements.txtallows users to install GKE extras (pip install 'pathwaysutils[gke]') and CI runners to install test dependencies (pip install 'pathwaysutils[test]').Implementation (How)
pyproject.tomlto addgke(kubernetes,pyyaml) andtest(kubernetes,pyyaml,pytest) to[project.optional-dependencies].requirements.txtto includekubernetesandpyyaml.Impact (What)
pip install 'pathwaysutils[gke]'andpip install 'pathwaysutils[test]'.